llnl / llnl/CHAI

Fix dynamic_pointer_cast for managed_ptr

Open
#221 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
111
Forks
23
Avg merge
2d 7h
Merged PRs (30d)
4

Description

The CPU pointer is cast using dynamic_cast, but the GPU pointer is cast using a static_cast. The latter needs to be changed to a dynamic_cast.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the CHAI source for managed_ptr and dynamic_pointer_cast, then inspect the GPU pointer cast alongside the CPU cast. The issue is done when the GPU path uses the same dynamic-cast behavior described in the report; no test file is identified in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.