llnl / llnl/CARE

Add macro guards for function overloads only needed when implicit conversions are enabled

Open
#39 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
32
Forks
7
Avg merge
19h 49m
Merged PRs (30d)
14

Description

See checkSorted in array_utils.h for an example.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with checkSorted in array_utils.h, the example named in the issue, and inspect nearby function overloads and their existing preprocessor conditions. Determine which overloads depend on implicit conversions; done means those overloads are consistently guarded while the always-supported overloads remain available.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.