lllyasviel / lllyasviel/stable-diffusion-webui-forge

[Bug]: Soft Inpainting does not fully disable

Open
#553 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
13k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Description

### Checklist

- [ ] The issue exists after disabling all extensions
- [ ] The issue exists on a clean installation of webui
- [ ] The issue is caused by an extension, but I believe it is caused by a bug in the webui
- [X] The issue exists in the current version of the webui
- [ ] The issue has not been reported before recently
- [ ] The issue has been reported before but has not been fixed yet

### What happened?

I did some experimenting with soft inpainting yesterday. Today even though I have soft inpainting turned off, I'm seeing ghosts of what was in the picture before in the hard inpainting areas, which never happened before I enabled and disabled soft inpainting.

The ghosts are eliminated if i grossly exaggerate the inpainting, which makes me further suspect that there's something in the soft inpainting code that's not being fully turned off.

### Steps to reproduce the problem

1. Enable soft inpainting
2. Disable soft inpainting
3. Inpaint image
4. Output shows ghost images of what was in the inpainted area in outside areas of inpainting (those closes to the inpaint border)

### What should have happened?

Now that soft inpainting is disabled, I shouldn't be seeing any artifacts from the hard inpainting areas. These artifacts appear to be applied at the very end of the render, as I don't see them at all in the preview images, only in the finished product.

### What browsers do you use to access the UI ?

Mozilla Firefox, Google Chrome, Microsoft Edge

### Sysinfo

[sysinfo-2024-03-13-20-38.json](https://github.com/lllyasviel/stable-diffusion-webui-forge/files/14593821/sysinfo-2024-03-13-20-38.json)

### Console logs

```Shell
Is there a way to enable logging in the forge startup flags?
```

### Additional information

No recent changes except for enabling soft inpainting, then disabling it today.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with the listed steps in a clean webui installation, comparing preview images with the finished output. The payload names no source file or test, so trace the soft-inpainting toggle and final rendering path from the reproduction. Done means disabling soft inpainting no longer leaves artifacts near hard inpainting borders.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
machine-learning
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.