lllyasviel / lllyasviel/stable-diffusion-webui-forge
Latent NoneType issue
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 13k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
Function `manage_model_and_prompt_cache` is executed before `process_images_inner`, thus may cause an issue: when `forge_model_reload` finds the model is same as the loaded, it still has a chance to trigger `unload_all_models`, which fails `process_images_inner` (sd_model is None now).
https://github.com/lllyasviel/stable-diffusion-webui-forge/blob/dfdcbab685e57677014f05a3309b48cc87383167/modules/processing.py#L836
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in modules/processing.py around line 836, where process_images_inner is referenced, and trace the order of manage_model_and_prompt_cache and forge_model_reload. Reproduce the case where the model is unchanged and unload_all_models runs before processing; done means process_images_inner no longer receives sd_model as None.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100