lllyasviel / lllyasviel/stable-diffusion-webui-forge
Stopping batch generation is completely broken
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 13k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
If you have a high batch count, and press Ctrl+Enter to stop generation, it does something weird, but it doesn't stop generation.
- start generation (with batch count set to something high enough that it will take a while to finish)
- before it finishes normally, press Ctrl+Enter to stop it early
- it changes the GUI buttons to the idle state
- but it actually keeps generating images
- there's no way to stop it (you can only wait until it finishes the entire batch, or you can kill it)
It works if you press the "interrupt" button on the GUI with the mouse. Obviously I don't want to use the button. If I wanted to practice hitting stuff with the mouse, I'd use comfyui.
This is actually a really old bug that re-appears in various forms. In all of them, the GUI state and the actual state in the server become desynced. The GUI thinks it's not generating anymore, and you can't stop it by sending a stop signal to the server.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with a high batch count and Ctrl+Enter, then trace how that shortcut communicates with the server and updates the GUI state. Compare its behavior with the working GUI interrupt button. Done means Ctrl+Enter stops image generation on the server and leaves the GUI in the correct idle state.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend, frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100