lllyasviel / lllyasviel/stable-diffusion-webui-forge
Hiresfix Button Behavior Reverted | Is Broken
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 13k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
I believe you've broken the behavior if the hiresfix button. I had suggested an update to it months back and it was implemented. This last update seems to have reverted it's behavior. Tbh this is very important to me.
Expected behavior
original image 10x10
hit hiresfix button at 2x scale
new image should be 20x20 and it is indeed BUt
hit hiresfix button again at 2x scale
new image should be 40x40 but it is not. it just keeps making 20x20 images
The 2X is supposed to be applied to the currently selected photo in the gallery but it's not. Despite choosing the 20x20 image, it's not having 2X applied to it.
REALLY hope this gets fixed quickly. Guess I'll go back a version.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file, test, or entry point is named. Reproduce the hiresfix sequence with a 10x10 image at 2x, then apply it again to the resulting 20x20 gallery selection. Done means the second operation produces a 40x40 image and repeated scaling uses the currently selected photo.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 32/100