lllyasviel / lllyasviel/stable-diffusion-webui-forge
Looks like they hardcoded CLIP skip = 2 in SDXL?
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 13k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
Looks like they hardcoded CLIP skip = 2 in SDXL?
https://github.com/lllyasviel/stable-diffusion-webui-forge/blob/4a30c157691a33c2cc6e8d4fe861907429428f1e/backend/diffusion_engine/sdxl.py#L42-L68
Right here, when the network's created, they set minimal_clip_skip = 2.
And in the call chain, it always ends up with -max(self.clip_skip, self.minimal_clip_skip) ≡ -max(self.clip_skip, 2) ≡ -2
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with backend/text_processing/classic_engine.py at the linked lines and backend/diffusion_engine/sdxl.py around lines 42-68. Trace how minimal_clip_skip and clip_skip reach the final value, then compare that behavior with the issue's expected configurability. Done means the SDXL CLIP skip behavior is verified and any required correction is covered by an appropriate test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100