lllyasviel / lllyasviel/stable-diffusion-webui-forge

[Bug]: Hires.fix doesn't work correctly it doesn't understand the [a:b:when to switch] advanced prompt correctly destroying the image

Open
#2,565 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
13k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Description

Hires.fix prompt doesn't work as expected when you use [a🅱️when to switch]

I will take this simple prompt as example

[(a red apple):(a green apple:1.8):1.0] (I've increased the weight of the prompt that should not be included so is more obvious that it will influence the prompt)

in the current configuration the prompt is basically (a red apple) because the steps weight is set to 1.0 (should never switch to the second part a green apple).

without Hires.fix the output image results in a red apple because the "green apple" will never trigger.

Image

enabling Hires.fix (SwinR_4x, Denoising 0.6) will result in the prompt getting combined in a weird way

Image

enabling in the settings the Hires.fix prompts to be visible and adding only the (a red apple) prompt as it should be if the [a🅱️when to switch] formula would had worked results in the expected image

Image

additional info:

adding the [(a red apple):(a green apple:1.8):1.0] to Hires.fix prompt, same thing

.

enabling in the settings the "Use old prompt editing timelines" option changes the hirez image but it is still broken and not how expected

Image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the reported prompt with Hires.fix enabled and disabled, using the [a🅱️when to switch] syntax, SwinR_4x, and denoising 0.6. Trace how Hires.fix handles prompt editing timelines and compare it with the visible Hires.fix prompt behavior; done means the weighted prompt remains the red-apple-only result when the switch value is 1.0.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
ai
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.