lllyasviel / lllyasviel/stable-diffusion-webui-forge
Support for T5 embeddings
- Dominant language
- Python
- Stars
- 13k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
Currently, textual inversion embeddings for multiple text encoders only works with SDXL - https://github.com/lllyasviel/stable-diffusion-webui-forge/blob/main/modules/textual_inversion/textual_inversion.py#L291
I'd like to be able to use an embedding for T5 as well. ComfyUI looks for the key in the safetensor dict 't5xxl'. I'm able to use embeddings with Flux in Comfy that have the keys ['clip_l', 't5xxl'].
Contributor guide
No contributing guide indexed for this repository
Research direction
Start in modules/textual_inversion/textual_inversion.py around line 291, where multi-text-encoder textual inversion handling is limited to SDXL. Trace how safetensor keys are selected and compare the existing behavior with Flux embeddings containing 'clip_l' and 't5xxl'. Done means embeddings with the 't5xxl' key can be used with T5-based models.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100