lllyasviel / lllyasviel/stable-diffusion-webui-forge
Add setlocal and endlocal to Environment Script to Prevent System-Wide Changes
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 13k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
I've encountered an issue where updating Forge WebUI affects all environments on my machine. This caused problems for one of my projects, requiring a complete reinstallation of dependencies. As a non-programmer, it's challenging to manage these changes. Adding setlocal and endlocal to the environment script would help keep changes local to the current script, avoiding system-wide modifications.
```
@echo off
setlocal
set DIR=%~dp0
set PATH=%DIR%\git\bin;%DIR%\python;%DIR%\python\Scripts;%PATH%
set PY_LIBS=%DIR%\python\Scripts\Lib;%DIR%\python\Scripts\Lib\site-packages
set PY_PIP=%DIR%\python\Scripts
set SKIP_VENV=1
set PIP_INSTALLER_LOCATION=%DIR%\python\get-pip.py
set TRANSFORMERS_CACHE=%DIR%\transformers-cache
endlocal
```
Not sure if this will fix it but something so that it doesn't change more variable than it needs to would be helpful! Thank you for all the work you do!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the environment script referenced in the issue and read how it currently sets PATH and Python-related variables. Test whether those changes persist outside the script, then verify that the environment is isolated without disrupting Forge WebUI startup.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- devops
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100