lllyasviel / lllyasviel/stable-diffusion-webui-forge
Checkpoint, clip skip and vae settings are not saved normally between sessions.
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 13k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
Could be a side effect of my fiddling, but none of the gr.state variables are getting saved to the current value.
When one presses "Apply settings" (ie during run_settings), the value which these three gr.state components sends is always the default, thus upon reload they'll be set to: sd_model_checkpoint to null then the first in the list, CLIP_stop_at_last_layers to 1, sd_vae to Automatic (though irrelevant to forge).
As such, I think it would be preferable to exclude any gr.state components from the standard save - it's noted these are meant to be managed by forge anyway.
If anyone with a more standard install can confirm this glitch, that'd be swell.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at run_settings and trace how the gr.state variables sd_model_checkpoint, CLIP_stop_at_last_layers, and sd_vae are read during “Apply settings.” Confirm the behavior on reload and ensure the three state values no longer overwrite their current settings during the standard save; verify that checkpoint, CLIP, and VAE settings persist normally between sessions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend, machine-learning
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100