lllyasviel / lllyasviel/stable-diffusion-webui-forge
Extra Networks search returns irrelevant results
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 13k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
I've noticed that Forge imported the same upstream issue as [reForge did here](https://github.com/Panchovix/stable-diffusion-webui-reForge/issues/43), where the extranetworks.js also looks for search terms in the model description. This often returns irrelevant results and sends genuine results deep into the list, especially when searching for common terms.
E.g. searching for a hand-helper lora with "hand", which in my setup had a batman lora show up first while the hand lora required scrolling through a dozen+ results despite "hand" being in the name.
Potential fix could be removing description from [this line](https://github.com/lllyasviel/stable-diffusion-webui-forge/blob/main/javascript/extraNetworks.js#L66) in extra networks, or making an option for full description or filename-only search results in settings.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at javascript/extraNetworks.js line 66, where Extra Networks search terms are matched against model information including descriptions. Reproduce the "hand" search case, then verify that name or filename matches are ranked ahead of irrelevant description matches; the issue also suggests checking whether a settings option is needed for broader searches.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100