lllyasviel / lllyasviel/stable-diffusion-webui-forge
[Bug]: Copies of the reference image are being shown in the results per element in batch/hires/lowres/and each controlnet
- Dominant language
- Python
- Stars
- 13k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
### Checklist
- [x] The issue exists after disabling all extensions
- [x] The issue exists on a clean installation of webui
- [ ] The issue is caused by an extension, but I believe it is caused by a bug in the webui
- [x] The issue exists in the current version of the webui
- [ ] The issue has not been reported before recently
- [ ] The issue has been reported before but has not been fixed yet
### What happened?
When a controlnet is used the reference image resuting (openpose canny, depth etc) is being generated together with the output, this is fine. However the copies are quite excesive, for example generating a batch 2, using 3 networks (cany,depth and openpose), and the hires fix option set to both, will generate 1 grid image (if enabled) each ot the outputs, and 18 controlnet images.
Per image:
(1 canny highres, 1 canny lowres , 1 depth hires,1 depth lowres, 1 openpose hires, 1 openpose lores ) **These are all exactly the **same+****
An additional set < - I believe this is the only one being output in the extension.
So if you have a batchsize of 20 you will endup with 20 generated images and 126 controlnet images, of which 120 are duplicates.
This consumes way too many resources than needed, and makes browsing the results a pain.
If theres a specific usecase where the controlnet images would be different theres already an option to save to directory, having them on gallery would not be useful anyway.
### Steps to reproduce the problem
Use controlnet with any image and model, observe the copies of controlnet in the result
### What should have happened?
Current controlnet extension only shows the final reference image for each preprocesor (and only 1 version)
### What browsers do you use to access the UI ?
_No response_
### Sysinfo
[sysinfo-2024-02-07-15-44.json](https://github.com/lllyasviel/stable-diffusion-webui-forge/files/14210894/sysinfo-2024-02-07-15-44.json)
### Console logs
```Shell
N/A
```
### Additional information
_No response_
Contributor guide
No contributing guide indexed for this repository
Research direction
Reproduce the issue with ControlNet, a batch, and hires fix enabled, then trace how preprocessor reference images are added to the results gallery. Done means the gallery shows only one final reference image per preprocessor and version, without duplicate batch, hires, lowres, or controlnet entries.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- frontend, machine-learning
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100