lllyasviel / lllyasviel/stable-diffusion-webui-forge
Fix loras having a weak effect when applied on fp8. - [Comfy Pushed fix for thsi - Can we get in Forge]
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 13k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
Please see this commit that Comfy pushed earlier today that fixes the issue where some Flux LoRA are very weak when using along w/ fp8. It would be great if Forge were similarly updated so there is consistency:
https://github.com/comfyanonymous/ComfyUI/commit/bb222ceddb232aafafa99cd4dec38b3719c29d7d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the referenced ComfyUI commit and comparing its fp8 LoRA fix with the corresponding Forge implementation. The issue names no Forge files or tests, so locate the Flux LoRA and fp8 entry points before determining the matching change. Done means Flux LoRA no longer has a weak effect when used with fp8 and behavior is consistent with ComfyUI.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100