lllyasviel / lllyasviel/ControlNet

Question about Figure 3 in the paper

Open
#648 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
34.1k
Forks
3k
PR merge metrics
No merged PRs in 30d

Description

Hi authors, I have a small question about the following piece of code and Figure 3.

```
1. for module, zero_conv in zip(self.input_blocks, self.zero_convs):
2. if guided_hint is not None:
3. h = module(h, emb, context)
4. h += guided_hint
5. guided_hint = None
```

If I understand correctly, `h` should be the input z_t in Figure 3, `guided_hint` should be condition `c_f` in Figure 3.

Why we feed `h` through `module` and then add with `guided_hint` (Line 3-4)? According to Figure 3, shouldn't we add `h` with `guided_hint` directly? (Line 5)

Thank you for answering!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the Figure 3 description in the paper alongside the shown input_blocks loop, focusing on the roles of h and guided_hint and the order of the module call and addition. Resolve whether the implementation matches the figure, then document the explanation for the questioned lines.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
machine-learning
Issue type
Documentation
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.