liveview-native / liveview-native/liveview-native-core
Rework the parsing logic to be more resiliant against non-compliant html
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 166
- Forks
- 14
- PR merge metrics
- No merged PRs in 30d
Description
This is a sibling issue to https://github.com/liveview-native/liveview-client-swiftui/issues/1410.
Currently if [parsing fails a `ParseError` is returned from core](https://github.com/liveview-native/liveview-native-core/blob/b90358dce5db4d4a5a17297a092e5021f81b2da9/crates/core/src/dom/mod.rs#L137-L139). It's still an error but similar to browsers the parsing should be resilient to erroneous elements.
This might involve modifying [the liveview-native fork of `htmlgum` on the `lvn` branch](https://github.com/liveview-native/html5gum/tree/lvn).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the parsing failure path in crates/core/src/dom/mod.rs, especially the linked ParseError return. Then inspect the liveview-native/html5gum fork on its lvn branch and the sibling issue #1410 for related context. Done means parsing tolerates erroneous HTML elements in a browser-like way without returning an error for cases covered by the agreed behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- web-dev
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100