liveview-native / liveview-native/liveview-client-swiftui

Remove `tag` attribute

Open
#1,468 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Swift
Stars
440
Forks
45
PR merge metrics
No merged PRs in 30d

Description

Supporting tag="..." deviates from our typical SwiftUI View -> template mapping.

The tag(...) modifier should be used instead. This modifier will need to be implemented with the following signature:

func tag(_ tag: String?) -> some View

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the SwiftUI View-to-template mapping and inspect how the tag attribute and other view modifiers are handled. Remove the attribute support, implement the specified tag(_:) modifier, and verify that the mapping uses the modifier instead.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.