liveview-native / liveview-native/liveview-client-swiftui

Changes to attr in rules parser

Open
#1,317 0 comments 0 reactions 1 assignee View on GitHub

@NduatiK is already working on this.

Since Apr 17, 2024.

Dominant language
Swift
Stars
440
Forks
45
No merged PRs in 30d

Description

We want to more closely align with CSS's own format: https://developer.mozilla.org/en-US/docs/Web/CSS/attr

  1. attr(foo-bar) should be supported without quotes. In fact we want to drop support for the quoted version
  2. attr(foo-bar, "default") should use the 2nd argument as a default value if the first attribute results in an empty string

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.