livepeer / livepeer/verification-classifier

Return calculated pixels in "pixels" field for a rendition in API response

Open
#128 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Jupyter Notebook
Stars
8
Forks
6
PR merge metrics
No merged PRs in 30d

Description

Currently, the pixels field for a rendition in the API response is whatever value is contained in the pixels field for the API request. I think this is confusing. Instead, the pixels field for a rendition in the API response should contain the value calculated by the verifier so that the user of the verifier can compare the value with an expected value.

The verifier already calculates the pixels, but this information is incorporated into the `pixels_pre_verification` and `pixels_post_verification` fields with the former being the ratio b/w the expected pixels (indicated in the request) and the pixels calculated based on metadata and the latter being the ratio b/w the expected pixels and the pixels calculated based on reading the frames.

Note that while working on this issue we should also look into whether the pixels calculated by the verifier matches up with the pixels calculated by LPMS. I saw in some local testing with a verifier + broadcaster + orchestrator an API response with `pixels_post_verification: 6.0` which would imply that the verifier calculated a different # of pixels than the expected value passed to the verifier by the broadcaster which is calculated by LPMS (on the orchestrator)...

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the verifier's calculated pixel values and the code that builds the rendition API response. Compare those values with the pixels supplied by LPMS through the broadcaster and orchestrator, including the pixels_pre_verification and pixels_post_verification ratios. Done means the response's pixels field reports the verifier-calculated value and any discrepancy with LPMS is understood.

Written by the indexing model from the issue text.

Assessment

Domain
api, backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.