livepeer / livepeer/stream-tester
mist-api-connector: end use of CONN_CLOSE
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 24
- Forks
- 10
- PR merge metrics
- No merged PRs in 30d
Description
CONN_CLOSE considered harmful, from @Thulinma. We should stop using it for deciding when streams end. Instead we should use the STREAM_BUFFER trigger and wait for its "empty" state.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the mist-api-connector code and trace where CONN_CLOSE currently decides that streams have ended. Replace that decision path with the STREAM_BUFFER trigger and verify the connector waits for its "empty" state; the issue names no tests, so identify the relevant test coverage while tracing the behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- stream-processing
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100