Remove SafeMath from the protocol's dependencies
@kautukkundan is already working on this.
Since May 10, 2022.
- Dominant language
- JavaScript
- Stars
- 155
- Forks
- 50
- PR merge metrics
- No merged PRs in 30d
Description
Since solidity 0.8.x [all arithmetic is checked by default](https://github.com/ethereum/solidity/blob/develop/Changelog.md#:~:text=Code%20Generator%3A%20All%20arithmetic%20is%20checked%20by%20default.%20These%20checks%20can%20be%20disabled%20using%20unchecked%20%7B%20...%20%7D.) which makes the explicit usage of OpenZeppelin SafeMath unnecessary.
As the protocol switched to Solidity 0.8.9, it's safe to remove OZ SafeMath from its dependencies (i.e.: [here](https://github.com/livepeer/protocol/blob/confluence/contracts/bonding/BondingManager.sol#L2) and [here](https://github.com/livepeer/protocol/blob/confluence/contracts/pm/mixins/MixinReserve.sol#L6)).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.