Add unit test for missing SPS/PPS at beginning of segment
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 283
- Forks
- 72
- Avg merge
- 27m
- Merged PRs (30d)
- 1
Description
If the `force-idr` option is omitted from the encoder AVOptions while using nvidia transcoding, there will be decode errors at the beginning of playback. However, disabling this option currently doesn't lead to any unit test failures. We really should check that SPS/PPS aways exists via unit tests as a way of preserving this behavior.
Ideally this option wouldn't be needed at all; ffmpeg itself should but smart enough to emit extradata for the first frame after a flush; that would mitigate the need for the `force-idr` option.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the NVIDIA transcoding encoder options and the existing unit tests covering segment startup or SPS/PPS handling. Reproduce playback with `force-idr` omitted, then add a test that verifies SPS/PPS exists at the beginning of a segment and run the relevant test package.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100