livepeer / livepeer/livepeer-data
review #1
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 1
- Forks
- 4
- PR merge metrics
- No merged PRs in 30d
Description
Here
https://github.com/livepeer/livepeer-data/blob/cfda3ec676f6339522b550e6035d4fb44e0676cf/health/record.go#L90
is data race.
Here
https://github.com/livepeer/livepeer-data/blob/cfda3ec676f6339522b550e6035d4fb44e0676cf/pkg/event/stream_consumer.go#L91
it can write to `msgChan` after it was closed here
https://github.com/livepeer/livepeer-data/blob/cfda3ec676f6339522b550e6035d4fb44e0676cf/pkg/event/stream_consumer.go#L111
Here
https://github.com/livepeer/livepeer-data/blob/cfda3ec676f6339522b550e6035d4fb44e0676cf/health/core.go#L136
and here
https://github.com/livepeer/livepeer-data/blob/cfda3ec676f6339522b550e6035d4fb44e0676cf/health/core.go#L106
`LastStatus` being copied not under the lock.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked lines in health/record.go, health/core.go, and pkg/event/stream_consumer.go, tracing the locking and channel lifecycle around each reported access. Done means the reported data race, unsynchronized LastStatus copies, and writes to msgChan after closure are addressed without introducing new concurrency failures.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100