livepeer / livepeer/go-tools

Remove unused methods

Open
#14 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
0
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Confirm if IsExternal is used anywhere (i.e in other repos) and if so, document more clearly what its intended us is but otherwise remove.

Check other methods on the same interface.

https://github.com/livepeer/go-tools/blob/44cbd85855e79c9a8d9327598e0a95d9261c0351/drivers/drivers.go#L126

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at drivers/drivers.go around the linked interface and inspect IsExternal along with the other methods on that interface. Search the repository and related Livepeer Go repositories to determine whether IsExternal is used and what its intended behavior is. Done means documenting the method clearly if it is used, or removing it and any other confirmed-unused methods.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.