livepeer / livepeer/go-livepeer

CLI should indicate failure when "15. Set transcoder config" is invoked on a block within the RoundLockAmount

Open
#837 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area: cli need: investigation status: icebox
Dominant language
Go
Stars
586
Forks
226
Avg merge
1d 17h
Merged PRs (30d)
19

Description

**Describe the bug**
If process `15. Set transcoder config` is invoked from the CLI when the current block is within `RoundLockAmount` of the next round, the CLI prints the following message:

```
Transaction sent. Once confirmed, please restart your node if the ServiceURI has been reset
```

This is incorrect since the transaction isn't created. The CLI should print a clear message that the parameters cannot be changed due to the `RoundLockAmount` restriction.

**To Reproduce**
Steps to reproduce the behavior:
1. Launch the CLI.
2. Invoke `15. Set transcoder config`.
3. Provide parameter values (they can be the same or different as the previous values).
4. Check transactions coming from your transcoder's address (e.g. via Etherscan) and you will see that no transaction is created.

**Expected behavior**
When the current block is within `RoundLockAmount` of the next round, I expect the CLI to provide an error stating that a transaction for parameter change cannot be created.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the CLI entry point for `15. Set transcoder config` and reproduce the case where the current block is within `RoundLockAmount` of the next round. Trace transaction creation and failure reporting; done when this condition produces a clear error and no success message, with coverage for the restricted case.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
blockchain, cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.