livepeer / livepeer/go-livepeer-basicnet
Check for nodeID when calling `UpdateMasterPlaylist`
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 18
- Forks
- 6
- PR merge metrics
- No merged PRs in 30d
Description
A node should only be able to update the master playlist from a local stream. Even though the current implementation only updates a local copy, semantically, it should throw an error if the NodeID portion of the StreamID doesn't match the local NodeID.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the UpdateMasterPlaylist entry point and read how StreamID and the local NodeID are currently handled. Verify the behavior for a remote NodeID, then add the requested error path and check the existing tests around master playlist updates, if present. Done means a non-local stream cannot update the master playlist.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100