live-codes / live-codes/livecodes

Refactoring core.ts

Open
#826 9 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.5k
Forks
267
Avg merge
9h 40m
Merged PRs (30d)
16

Description

Hi,

While working on another PR I noticed that `core.ts` was extremely long and it was a little hard to figure out how to implement some changes so I am planning on refactoring that code into multiple modules to make it more maintainable.
For example, `core.ts` has 98 functions
```bash
$ grep -c "= () =>" src/livecodes/core.ts
98
```

So I am thinking we could extract some modules from `core.ts` like a ConfigManager, EditorManager, StorageManger, etc. without changing the functions and then later we can refactor the long functions.

This might be too much for a single PR so maybe break the PRs into something like extracting ConfigManger from core.ts, extracting x etc.

What do you think?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.