litespeedtech / litespeedtech/lsquic
send_batch function cant handle socket err on win32
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 1.9k
- Forks
- 397
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 8
Description
Hi, the send_batch function in lsquic_engine.c has some socket error handling according to errno it catched after packets_out. However, in send_packets_one_by_one function, socket error would not be assigned to error on win32, the errno would be zero on win32 even socket has some sending errors
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in lsquic_engine.c and compare the socket-error handling in send_batch with send_packets_one_by_one, focusing on the Win32 path after packets_out. Confirm how sending errors are represented when errno is zero on Win32. Done means send_packets_one_by_one provides the error information that send_batch expects for failed socket sends.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100