litespeedtech / litespeedtech/lscache_wp

WooCommerce My Account shortcode as ESI block doesn't show messages

Open
#900 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
257
Forks
123
PR merge metrics
No merged PRs in 30d

Description

Related: #899

In the above issue I mention that I've fixed an issue with login using an ESI wrapper for the my account shortcode.
However, as an ESI block, this shortcode does not output any error messages anymore, for example when providing an incorrect password.

Reproducible on any page containing [esi woocommerce_my_account ttl=0].

Environment

  • Platform: WordPress WooCommerce Multisite
  • Webserver / cache: LiteSpeed (LSCache, ESI enabled)
  • CDN / proxy: Cloudflare (Dev Mode used during testing)
  • Security plugin: Wordfence (tests done with IP whitelisted)
  • PHP / WordPress / Plugin versions: WP 6.8.2, LS 7.5.0.1, Woo 10.1.2,

Converting this to a regular non-ESI shortcode will show the error messages again.

Issue also reported here: https://wordpress.org/support/topic/woocommerce-my-account-shortcode-as-esi-block-doesnt-show-messages/

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the problem with a page containing [esi woocommerce_my_account ttl=0], using an incorrect password, and compare it with the regular shortcode behavior. Trace the ESI response handling and WooCommerce message output; done means login error messages are visible in the ESI block as they are in the non-ESI shortcode.

Written by the indexing model from the issue text.

Assessment

Tech stack
php, wordpress
Domain
backend, performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.