litespeedtech / litespeedtech/lscache_wp
Double admin bar in modern themes
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 257
- Forks
- 123
- PR merge metrics
- No merged PRs in 30d
Description
In WordPress 5.4 the render of the admin bar was moved to the wp_body_open action.
With ESI enabled any theme which uses wp_body_open will end up with two copies of the admin bar.
One near the beginning of the html (wherever the theme calls wp_body_open) and one at the old position at the end of the footer.
Due to CSS these will normally visually end up overlaid on top of each other so it isn't visually obvious there are two of them, but if any javascript is used to modify the admin bar (e.g. the Elementor plugin adds its "Edit in Elementor" menu using javascript) then it will most likely modify the first hidden admin bar but not the second visible admin bar.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with ESI enabled in a WordPress 5.4 theme that calls wp_body_open, then compare the admin-bar render near the start of the HTML with the copy at the end of the footer. Done means only one admin bar is rendered and JavaScript changes, such as Elementor's menu modification, affect the visible bar.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php, wordpress
- Domain
- backend, web-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100