litespeedtech / litespeedtech/lscache_wp
API key notification shown when not using Quic Cloud
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 257
- Forks
- 123
- PR merge metrics
- No merged PRs in 30d
Description
I noticed that the dashboard notification shows asking for an API key to use the online services, even though I do not have those settings enabled. Looking at the code, I believe this is caused by the following lines in the show_promo() function:
```
if ( ! $this->_api_key ) {
Admin_Display::error( Error::msg( 'lack_of_api_key' ), true );
}
```
If I understand correctly, this means that an API key is being requested every time a promo/notification is requested. Can we remove this requirement? The notification which requests the API key is confusing when that service is not required.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the show_promo() function and inspect the lack_of_api_key notification check shown in the issue. Verify the behavior with online-service settings disabled and enabled; done means the API-key notification is absent when the service is not required and remains available when it is.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php, wordpress
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100