litespeedtech / litespeedtech/lscache-drupal
Upgrade for Drupal 10
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 15
- Forks
- 19
- PR merge metrics
- No merged PRs in 30d
Description
I may well do the work for this, but do not yet have time.
The two issues picked up by PHPstan are:
File: web/modules/contrib/lite_speed_cache/src/EventSubscriber/LiteSpeedCacheSubscriber.php
Line: 128
Comment: Parameter $event of method Drupal\lite_speed_cache\EventSubscriber\LiteSpeedCacheSubscriber::onRouteMatch() has typehint with deprecated class Symfony\Component\HttpKernel\Event\GetResponseEvent: since Symfony 4.3, use RequestEvent instead
File: web/modules/contrib/lite_speed_cache/src/EventSubscriber/LiteSpeedCacheSubscriber.php
Line: 166
Comment: Parameter $event of method Drupal\lite_speed_cache\EventSubscriber\LiteSpeedCacheSubscriber::onResponse() has typehint with deprecated class Symfony\Component\HttpKernel\Event\FilterResponseEvent: since Symfony 4.3, use ResponseEvent instead
and the .info.yml file needs to have "^9 || ^10" as the version requirement.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with web/modules/contrib/lite_speed_cache/src/EventSubscriber/LiteSpeedCacheSubscriber.php at lines 128 and 166, then locate the module's .info.yml file. Run PHPStan to confirm the deprecated Symfony event type findings, update the event type requirements, and set the Drupal version requirement to ^9 || ^10.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- drupal, php, symfony
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100