litespeedtech / litespeedtech/ls-qpack
Build Warnings Related to Spectre Mitigation
Open
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 86
- Forks
- 36
- PR merge metrics
- No merged PRs in 30d
Description
With the latest release, most build warnings went away, except for the following:
https://github.com/nibanks/msh3/actions/runs/3868034900/jobs/6593213121#step:7:118
D:\a\msh3\msh3\ls-qpack\deps\xxhash\xxhash.c(461): warning C5045: Compiler will insert Spectre mitigation for memory load if /Qspectre switch specified [D:\a\msh3\msh3\build\ls-qpack\ls-qpack.vcxproj]
D:\a\msh3\msh3\ls-qpack\deps\xxhash\xxhash.c(458): message : index 'p' range checked by comparison on this line [D:\a\msh3\msh3\build\ls-qpack\ls-qpack.vcxproj]
D:\a\msh3\msh3\ls-qpack\deps\xxhash\xxhash.c(461): message : feeds call on this line [D:\a\msh3\msh3\build\ls-qpack\ls-qpack.vcxproj]
...
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked GitHub Actions job and inspect the warning from deps/xxhash/xxhash.c in the ls-qpack.vcxproj build. Determine how this warning should be handled for the Windows build; done means the reported Spectre-related warning is resolved or its intended handling is documented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100