litespeedtech / litespeedtech/ls-hpack
CMake packaging: missing install() rules and modern CMake policy compatibility
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 56
- Forks
- 27
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 2
Description
Hi! Thanks for ls-hpack.
While packaging `ls-hpack` for Homebrew, I noticed two CMake usability issues:
1. `CMakeLists.txt` has no `install()` rules
- We can build `libls-hpack.a`, but `cmake --install` installs nothing.
- Packagers currently need manual install steps for headers + library.
2. Modern CMake compatibility
- With current CMake, configure fails unless we pass:
`-DCMAKE_POLICY_VERSION_MINIMUM=3.5`
- The project currently has:
`cmake_minimum_required(VERSION 2.8)`
Would you consider:
- adding install rules, e.g.
- `install(TARGETS ls-hpack ...)`
- `install(FILES lshpack.h lsxpack_header.h DESTINATION include)`
- and bumping/modernizing CMake minimum/policy handling?
Happy to test a patch.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with CMakeLists.txt and inspect the existing target configuration for libls-hpack.a. Test cmake --install and a configure run with current CMake; done means installation provides the library and lshpack.h and lsxpack_header.h, while configuration works without the noted policy workaround.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, cmake
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100