lit / lit/lit

[labs/ssr] Consider other DOM shims for ARIA attr reflection during SSR

Open
#3,741 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
21.8k
Forks
1.1k
Avg merge
18h 25m
Merged PRs (30d)
2

Description

### Should this be an RFC?

- [X] This is not a substantial change

### Which package is this a feature request for?

SSR (@lit-labs/ssr)

### Description

Context: https://github.com/lit/lit/pull/3677#discussion_r1142827432

The ARIA attribute reflection logic in `LitElementRenderer` is dependent on our implementation of `attachInternals()` for `HTMLElement` in `@lit-labs/ssr-dom-shim` and may not work for users of other DOM shims. Currently `jsdom` nor `happy-dom` implement `attachInternals()` so there's nothing to support but we'll have to address this as `ElementInternals` gets wider adoption.

### Alternatives and Workarounds

.

Contributor guide

Open the contributing guide

Research direction

Start with LitElementRenderer and the attachInternals() implementation in @lit-labs/ssr-dom-shim. Compare the assumptions there with the DOM behavior exposed by jsdom and happy-dom, then determine what compatibility should look like as ElementInternals support expands. Done should include an agreed approach for ARIA reflection with other DOM shims.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
web-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.