lit / lit/lit

[lit-starter-*] starter kits require `override` which isn't documented

Open
#2,214 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
21.8k
Forks
1.1k
Avg merge
18h 25m
Merged PRs (30d)
2

Description

#2060 enabled `noImplicitOverride` in all of the `lit` monorepo, including the starter kit projects.

The examples on the doc site don't use the `override` keyword, which means you can't copy/paste them into a starter kit project.

We should either 1) roll this change back for the starter kits, or 2) update all of the sample code on the site.

I vote for #1, personally.

Contributor guide

Open the contributing guide

Research direction

Review the noImplicitOverride change from #2060 and inspect the starter kit projects alongside the doc-site sample code. Decide whether starter kits should avoid this requirement or whether all samples should be updated; done means copied examples work in the starter kits and the chosen behavior is consistent.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
developer-experience, documentation
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.