Broken link checker external test also checking internal links
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 142
- Forks
- 230
- PR merge metrics
- No merged PRs in 30d
Description
In order to timebox fix the external link checker now also checks internal links, leading to a duplication of testing. This was done to fix the broken link checker timing out after crawling off the localhost:8080 domain in https://github.com/lit/lit.dev/pull/438
Acceptance criteria:
- Either combine tests into a single test that checks both internal and external links, or figure out how to filter out the redirect to slack.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the external link checker changes in pull request #438 and reproduce its behavior against localhost:8080. Trace why the external-link test also visits internal links, then make the tests avoid duplicated coverage or filter the Slack redirect; verify that internal and external link checks still cover their intended cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- testing, web-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100