lit / lit/lit.dev

Enable dedupe in rollup after MWC is using Lit 2.

Open
#420 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
142
Forks
230
PR merge metrics
No merged PRs in 30d

Description

Lit.dev is using lion components for the search navigation which use Lit 2 but we haven't upgraded whilst MWC is still on Lit 1. That means if we dedupe with rollup we break lion/core.

Issue created from excellent PR comment by Al: https://github.com/lit/lit.dev/pull/415#discussion_r683004550

Completion criteria:
- After MWC has migrated to Lit 2 we can upgrade lit.dev and re-enable dedupe in the rollup config.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

First verify that MWC has migrated to Lit 2, then inspect the rollup configuration where deduplication is disabled. Re-enable dedupe only after that migration and verify that lion/core and the search navigation still build and work correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
rollup, typescript
Domain
build-system
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.