lirios / lirios/fluid

Stop centering dialogs explicitely

Open
#306 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
QML
Stars
890
Forks
120
Avg merge
1d 7h
Merged PRs (30d)
1

Description

Since Qt 5.12 this is done automatically so we might want to stop doing it.
https://codereview.qt-project.org/c/qt/qtquickcontrols2/+/223303

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the dialog-centering code in the project and read the linked Qt code review for the Qt 5.12 behavior change. Verify which dialogs are affected and confirm that removing the explicit centering leaves them centered automatically.

Written by the indexing model from the issue text.

Assessment

Domain
frontend
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.