liquidvotingio / liquidvotingio/decidim-module-liquidvoting
Find all Decidim code that calls Proposal#update_votes_count
@davefrey is already working on this.
Since Apr 1, 2021.
- Dominant language
- Ruby
- Stars
- 4
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
Since our module is repurposing the proposals.proposal_votes_count attribute, we need to know what Decidim code calls Proposal#update_votes_count. We update the attribute a different way, and so any code that calls this method is unexpected and will corrupt our vote count.
We shouldn't ignore the calls, nor make the method a no-op, because both can result in corrupting the count.
One known example: rake db:seed will generate ProposalVote objects, which then updates the vote count attribute with a Decidim (not Liquidvoting) value.
Any found calls need to be adapted to insure only Liquidvoting is updating the vote count.
Related also to #48
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.