liquidvotingio / liquidvotingio/decidim-module-liquidvoting

Step up to supporting proposal lists, or not

Open
#50 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

technical debt
Dominant language
Ruby
Stars
4
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Proposal controllers set a variable from_proposals_list, it's carried as a param and used in views to conditionally render.

I think one thing it may be used for is allowing voting from the proposals view (rather than only on the specific proposal view).

I think our general approach until now has been to hardcode the variable to true, but it's not clear to me if we do it consistently, or if that's what we want.

This issue is to grok the variable's usage, choose to step up to using it dynamically or leave it static, and insure it's done consistently across our module.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect the proposal controllers, views, and every use of from_proposals_list to map how the parameter is set and consumed. Decide whether it should remain static or be determined dynamically, then verify that the chosen behavior is applied consistently across the module.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
full-stack
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.