liquidvotingio / liquidvotingio/api
Make global delegations explicit
Nobody has claimed this yet.
- Dominant language
- Elixir
- Stars
- 17
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Description
Currently it's implicit that, if a proposal_url is nil when creating a delegation, it means it's a global.
(Soon a nil voting method will also be part of that)
To somebody new to the codebase, and even to us, this is hard to tell.
We should refactor to make global delegations a deliberate, clear thing from the highest level and down.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing delegation creation from the highest-level entry point, focusing on how a nil proposal_url currently identifies global delegations and how a nil voting method will fit. Define the explicit global-delegation path and verify that delegation creation no longer relies on implicit nil values.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- elixir
- Domain
- backend-api-design
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100