liquidvotingio / liquidvotingio/api
Refactor to avoid mixing of Absinthe and business / data layers
Open
@jinjagit is already working on this.
Since Oct 21, 2020.
- Dominant language
- Elixir
- Stars
- 17
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Description
This refactor is needed following #152 (and #143), which currently make use of publish_voting_result_change/2 in lib/voting/voting_results.ex when either the Absinthe deleteDelegation or createDelegation action is called, respectively.
Also see @Oliver's [comment](https://github.com/liquidvotingio/api/pull/152#discussion_r508779587) in #152, and his [comment](https://github.com/liquidvotingio/api/issues/153#issuecomment-713103870) in #153, for further related details.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.