liquidmetal-dev / liquidmetal-dev/flintlock

Dir clean up on delete

Open
#371 10 comments 1 reaction 0 assignees View on GitHub
help wanted kind/bug lifecycle/stale priority/backlog
Dominant language
Go
Stars
1.5k
Forks
73
Avg merge
17h 24m
Merged PRs (30d)
30

Description

I don;t know whether this was intentional, but while before deletes cleared the dir structure back up to the namespace, now we leave the name dir as well.

Close if this is meant to be (it does look weird with dead capmvm names lying around)

Before delete:
```
/var/lib/flintlock/vm///
```

After delete:
```
/var/lib/flintlock/vm//
```

Ideally we would remove back to
```
/var/lib/flintlock/vm/
```
if all identically names mvms in that namespace are removed, and

```
/var/lib/flintlock/vm
```
if all mvms in that namespace are removed

Contributor guide

Open the contributing guide

Research direction

Trace the delete lifecycle responsible for the paths shown in the issue, starting with the code that removes a VM's UID directory. Verify how deletion behaves when the last VM with a name or namespace is removed, and confirm that the namespace and /var/lib/flintlock/vm directories are retained or removed as described.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
infrastructure
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.