liquidmetal-dev / liquidmetal-dev/flintlock

Validate `guest_mac` when supplied

Open
#242 9 comments 0 reactions 0 assignees View on GitHub
kind/feature lifecycle/stale priority/important-soon
Dominant language
Go
Stars
1.5k
Forks
73
Avg merge
17h 24m
Merged PRs (30d)
30

Description

**Describe the solution you'd like:**
If the guest mac is supplied in the create microvm api request we should validate the following:

- Its the correct format
- Multicast bit isn't set
- Its not the same as any other mac address in the request
- For a macvtap interface check that there isn't an existing interface with the name mac address on the host already

Q: do we care about the global/locally unique bit

**Why do you want this feature:**

To provide better feedback to the user

**Anything else you would like to add:**
[Miscellaneous information that will assist in solving the issue.]

Contributor guide

Open the contributing guide

Research direction

Start by locating the create microVM API request handling and where guest_mac values are processed; the issue names no files, tests, or entry points. Check how macvtap interfaces are identified on the host and define completion around format, multicast, duplicate, and existing-interface validation, including the unresolved global/local uniqueness question.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api, networking
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.