liquidmetal-dev / liquidmetal-dev/flintlock
Handle RegisterValidation errors in NewValidator
Open
Nobody has claimed this yet.
good first issue
help wanted
kind/refactor
priority/backlog
- Dominant language
- Go
- Stars
- 1.5k
- Forks
- 73
- Avg merge
- 17h 24m
- Merged PRs (30d)
- 30
Description
**Describe the solution you'd like:**
Right now the code has a `TODO` mark, so just resolve it.
**Why do you want this feature:**
No `TODO` comments should live in the code without filed issues to track them.
**Anything else you would like to add:**
https://github.com/weaveworks/flintlock/blob/main/pkg/validation/validate.go#L24,L27
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read pkg/validation/validate.go at the TODOs in NewValidator and inspect how RegisterValidation reports errors. Determine the intended error handling from the surrounding code; done means RegisterValidation errors are handled and the TODO comments are removed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100