liquidmetal-dev / liquidmetal-dev/cluster-api-provider-microvm

Record events when an action has been taken

Open
#51 1 comment 0 reactions 0 assignees View on GitHub
kind/feature
Dominant language
Go
Stars
157
Forks
21
PR merge metrics
No merged PRs in 30d

Description

**Describe the solution you'd like:**
We should create events at various points in the reconciliation. For example:

* Microvm created
* Microvm deleted

**Why do you want this feature:**

As well as conditions events are helpful to understand and react to things that have happened.

Sample from [capa](https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/571f447e7f4374eaca75a1dd6c0f2d9c9e8b1f1c/exp/controllers/awsmachinepool_controller.go#L225)

**Anything else you would like to add:**
[Miscellaneous information that will assist in solving the issue.]

Contributor guide

Open the contributing guide

Research direction

Start by tracing the reconciliation flow and compare its action points with the referenced capa example in awsmachinepool_controller.go around line 225. Define the events needed for actions such as microvm creation and deletion, then verify that reconciliation emits them at the appropriate points.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
infrastructure
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.