liquidmetal-dev / liquidmetal-dev/cluster-api-provider-microvm

Re-add condition checks in tests

Open
#324 0 comments 0 reactions 0 assignees View on GitHub
kind/feature
Dominant language
Go
Stars
157
Forks
21
PR merge metrics
No merged PRs in 30d

Description

**Describe the solution you'd like:**

In #318 teh assertions that related to updates to the resources where commented out. This is because the fake client no longer works as a api server does and patches etc fail.

**Why do you want this feature:**

**Anything else you would like to add:**
[Miscellaneous information that will assist in solving the issue.]

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the test changes referenced in #318 and identify the commented-out assertions for resource updates. Compare the fake client behavior with the API server behavior, restore the relevant condition checks, and confirm the affected tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.