liquidmetal-dev / liquidmetal-dev/battery

CI: add gosec security linter

Open Beginner friendly
#54 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

priority/medium
Dominant language
Go
Stars
1
Forks
0
Avg merge
2h 13m
Merged PRs (30d)
33

Description

.golangci.yml currently enables only the `standard` linter set plus errcheck/govet/staticcheck/unused/revive. There's no security-focused linter.

Add `gosec` to the golangci-lint config, and consider `bodyclose`/`contextcheck` too given the amount of gRPC/HTTP client code and context-passing in the reconciler and flintlock client packages.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with .golangci.yml and inspect the currently enabled linter set. Add gosec, then evaluate bodyclose and contextcheck against the gRPC/HTTP client code in the reconciler and flintlock client packages. Done means the CI linter configuration includes the intended security and context checks without introducing inappropriate findings.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
ci-cd, tooling
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
78/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.