liquid-labs / liquid-labs/condition-eval

Allow 'undefined' in expressions

Open
#23 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
JavaScript
Stars
0
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Overview

Sometimes we want to be able to say something like FOO || (BAR && FOO !== undefined) || FOO. In other words, if FOO is false (or 0, '', null, or some other false-y thing), then we want the result to be FOO so long as it's defined.

Deliverables

  • Implement.
  • Test.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the expression evaluator and its existing tests in the condition-eval repository. Review how false-y values and undefined are currently handled, then add coverage for the requested expression behavior and confirm the implementation passes the test suite.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.